Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update linting deps #24461

Merged
merged 1 commit into from
Jul 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/browser/api/net.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,10 @@ class ClientRequest extends Writable implements Electron.ClientRequest {
this._redirectPolicy = redirectPolicy;
}

get chunkedEncoding () {
return this._chunkedEncoding || false;
}

set chunkedEncoding (value: boolean) {
if (this._started) {
throw new Error('chunkedEncoding can only be set before the request is started');
Expand Down
2 changes: 0 additions & 2 deletions lib/common/asar_init.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
'use strict';

/* global require */

// Monkey-patch the fs module.
require('electron/js2c/asar').wrapFsWithAsar(require('fs'));
2 changes: 0 additions & 2 deletions lib/renderer/web-view/web-view-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ export class WebViewImpl {
this.internalElement.contentWindow!
);

// ResizeObserver is a browser global not recognized by "standard".
/* globals ResizeObserver */
// TODO(zcbenz): Should we deprecate the "resize" event? Wait, it is not
// even documented.
this.resizeObserver = new ResizeObserver(this.onElementResize.bind(this));
Expand Down
2 changes: 1 addition & 1 deletion lib/sandboxed_renderer/init.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint no-eval: "off" */
/* global binding, Buffer */
/* global binding */
import * as events from 'events';

const { EventEmitter } = events;
Expand Down
27 changes: 11 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,20 @@
"colors": "^1.1.2",
"dotenv-safe": "^4.0.4",
"dugite": "^1.45.0",
"eslint": "^5.13.0",
"eslint": "^7.4.0",
"eslint-config-standard": "^12.0.0",
"eslint-plugin-import": "^2.17.2",
"eslint-plugin-mocha": "^5.2.0",
"eslint-plugin-node": "^8.0.1",
"eslint-plugin-standard": "^4.0.0",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-mocha": "^7.0.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-standard": "^4.0.1",
"eslint-plugin-typescript": "^0.14.0",
"express": "^4.16.4",
"folder-hash": "^2.1.1",
"fs-extra": "^7.0.1",
"husky": "^2.2.0",
"klaw": "^3.0.0",
"lint": "^1.1.2",
"lint-staged": "^8.1.0",
"lint-staged": "^10.2.11",
"minimist": "^1.2.0",
"nugget": "^2.0.1",
"null-loader": "^4.0.0",
Expand Down Expand Up @@ -105,28 +105,23 @@
},
"lint-staged": {
"*.{js,ts}": [
"node script/lint.js --js --fix --only --",
"git add"
"node script/lint.js --js --fix --only --"
],
"*.{js,ts,d.ts}": [
"node script/gen-filenames.js",
"git add"
"node script/gen-filenames.js"
],
"*.{cc,mm,c,h}": [
"python script/run-clang-format.py -r -c --fix",
"git add"
"python script/run-clang-format.py -r -c --fix"
],
"*.md": [
"npm run lint:docs"
],
"*.{gn,gni}": [
"npm run gn-check",
"python script/run-gn-format.py",
"git add"
"python script/run-gn-format.py"
],
"*.py": [
"node script/lint.js --py --fix --only --",
"git add"
"node script/lint.js --py --fix --only --"
],
"docs/api/**/*.md": [
"node script/gen-filenames.js",
Expand Down
2 changes: 1 addition & 1 deletion spec-main/fixtures/module/remote-object-set.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const { BrowserWindow } = require('electron');

class Foo {
set bar (value) {
set bar (value) { // eslint-disable-line accessor-pairs
if (!(value instanceof BrowserWindow)) {
throw new Error('setting error');
}
Expand Down