perf: pass primitives directly through the context bridge, avoids copying #24531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Jul 13, 2020
codebytere
approved these changes
Jul 14, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
I have automatically backported this PR to "10-x-y", please check out #24551 |
|
@MarshallOfSound has manually backported this PR to "9-x-y", please check out #24746 |
MarshallOfSound
added a commit
that referenced
this pull request
Jul 27, 2020
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
MarshallOfSound
added a commit
that referenced
this pull request
Jul 28, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitives always use the prototypes of their accessing contexts, this means that we directly send primitives like strings and numbers over the bridge without copying. This reduces memory usage and improves performance as we don't have to serialize / deserialize needlessly.
Notes: Improved the performance of sending JS primitives over the context bridge