fix: ensure that errors thrown in the context bridge are created in the correct context

[MarshallOfSound]

This PR fixes two cases where errors were being created in context A but thrown in context B.

• When the V8 serializer threw an error, it always threw it in the source context, now it throws in the appropriate error context
• If we throw an error as a result of a return value failing to be converted, it created the error in the source context when it should create it in the destination context as that is where the error will be thrown / caught.

Notes: no-notes

[nornagon]

Would it also be correct to use TryCatch here to capture the error and throw a new error in the correct context? e.g.

Suggested change

	auto ret = PassValueToOtherContext(
	func_owning_context, calling_context,
	maybe_return_value.ToLocalChecked(), &object_cache,
	support_dynamic_properties, 0, BridgeErrorTarget::kDestination);
	v8::TryCatch try_catch(isolate);
	auto ret = PassValueToOtherContext(...);
	if (try_catch.HasCaught()) {
	ThrowException("Conversion of return value failed");
	return;
	}

[MarshallOfSound]

This is handled inside PassValueToOtherContext, the way that function is written and intended to be used is that it always does everything in the right context. Any errors thrown are thrown in the correct context too so this try catch would be unnecessary.

[nornagon]

Yeah, I was just thinking about this as an alternative implementation that would be less intrusive (i.e. there would no need for this extra enum).

[MarshallOfSound]

It means we'd have to trycatch every call to PassValueToOtherContext which would be considerably more intrusive?

[release-clerk]

No Release Notes

[trop]

I was unable to backport this PR to "7-3-x" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "10-x-y", please check out #24713

[trop]

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

[trop]

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #24747