chore: add V8 crash information to crashReporter #24771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
restore-fatalerrorcb
branch
from
a860b83
to
bc89ff5
Compare
codebytere
force-pushed
the
restore-fatalerrorcb
branch
from
bc89ff5
to
1569643
Compare
codebytere
changed the title
codebytere
force-pushed
the
restore-fatalerrorcb
branch
from
1569643
to
c0a3138
Compare
MarshallOfSound
approved these changes
Jul 29, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
@codebytere has manually backported this PR to "9-x-y", please check out #24864 |
|
@codebytere has manually backported this PR to "10-x-y", please check out #24866 |
nornagon
reviewed
Aug 5, 2020
Comment on lines
+148
to
+149
| volatile int* zero = nullptr; | ||
| *zero = 0; |
There was a problem hiding this comment.
Hm, why introduce new crash code rather than calling ElectronBindings::Crash()?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR restores our use of a custom V8 fatal error handler with the purpose of improving crash reports for crashes originating in V8. When a v8 crash occurs, the message and location will be added as extra parameters to the crash report for more effective debugging.
cc @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Added V8 crash message and location information to crashReport parameters.