Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: ensure symbol files are named lowercase on disk so that boto can find them #24857

Merged
merged 2 commits into from Aug 7, 2020
Merged

build: ensure symbol files are named lowercase on disk so that boto can find them #24857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
298f7a6
build: ensure symbol files are named lowercase on disk so that boto c…
MarshallOfSound Aug 5, 2020
a0fab43
build: only do the lower case symbol copy on case sensitive file syst…
MarshallOfSound Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions script/release/uploaders/upload-symbols.py
View file
Open in desktop
Expand Up @@ -2,8 +2,14 @@

import glob
import os
import shutil
import subprocess
import sys
import tempfile

def is_fs_case_sensitive():
with tempfile.NamedTemporaryFile(prefix='TmP') as tmp_file:
return(not os.path.exists(tmp_file.name.lower()))

sys.path.append(
os.path.abspath(os.path.dirname(os.path.abspath(__file__)) + "/../.."))
Expand Down Expand Up @@ -49,7 +55,19 @@ def main():

# The symbol server needs lowercase paths, it will fail otherwise
# So lowercase all the file paths here
if is_fs_case_sensitive():
for f in files:
lower_f = f.lower()
if lower_f != f:
if os.path.exists(lower_f):
shutil.rmtree(lower_f)
lower_dir = os.path.dirname(lower_f)
if not os.path.exists(lower_dir):
os.makedirs(lower_dir)
shutil.copy2(f, lower_f)
files = [f.lower() for f in files]
for f in files:
assert os.path.exists(f)

bucket, access_key, secret_key = s3_config()
upload_symbols(bucket, access_key, secret_key, files)
Expand Down