Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: setZoomLevel Chromium zoom policy #25105

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

morgan-sam
Copy link
Contributor

@morgan-sam morgan-sam commented Aug 24, 2020

Description of Change

Relating to #24505

Added description of Chromium zoom policy to docs with setZoomLevel method.

Checklist

  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Notes: none.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 24, 2020
@welcome
Copy link

welcome bot commented Aug 24, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2020
@zcbenz zcbenz merged commit e0611d0 into electron:master Sep 2, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2020

No Release Notes

@welcome
Copy link

welcome bot commented Sep 2, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@morgan-sam morgan-sam deleted the setZoomLevel-policy-docs branch September 2, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants