refactor: wire will-navigate up to a navigation throttle instead of OpenURL #25110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penURL (#25065) * refactor: wire will-navigate up to a navigation throttle instead of OpenURL * spec: add test for x-site _top navigation
nornagon
approved these changes
Aug 24, 2020
zcbenz
reviewed
Aug 25, 2020
|
|
||
| it('is triggered when a cross-origin iframe navigates _top', async () => { | ||
| await w.loadURL(`data:text/html,<iframe src="http://127.0.0.1:${(server.address() as AddressInfo).port}/navigate-top"></iframe>`); | ||
| await delay(1000); |
There was a problem hiding this comment.
(node:1098) UnhandledPromiseRejectionWarning: TSError: ⨯ Unable to compile TypeScript:
electron/spec-main/api-browser-window-spec.ts(507,17): error TS2304: Cannot find name 'delay'.
zcbenz
approved these changes
Aug 28, 2020
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25065
See that PR for details.
Notes: no-notes