test: add tests for shell.moveItemToTrash

[nornagon]

Description of Change

We didn't have tests for this before. now we do!

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
• This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: none

meant to comment, oops

[codebytere]

Looks like crashing:

Received signal 6
#0 0x00005c6f47af base::debug::CollectStackTrace()
#1 0x00005c6362e2 base::debug::StackTrace::StackTrace()
#2 0x00005c6f43fb base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x0000f7f900a0 ([vdso]+0x109f)
#4 0x0000f7f90079 ([vdso]+0x1078)
#5 0x0000f6024832 gsignal
#6 0x0000f6025cc1 abort
#7 0x00005c6f2f84 base::debug::BreakDebugger()
#8 0x00005c64d859 logging::LogMessage::~LogMessage()
#9 0x00005c64dd3f logging::LogMessage::~LogMessage()
#10 0x00005c632292 logging::CheckError::~CheckError()
#11 0x00005c6e042b base::internal::AssertBaseSyncPrimitivesAllowed()
#12 0x00005c702f0d base::Process::WaitForExitWithTimeout()
#13 0x00005c7032ae base::Process::WaitForExit()
#14 0x000058cbd4db (anonymous namespace)::XDGUtil()
#15 0x000058cbd1bb platform_util::MoveItemToTrash()
#16 0x000058c983b7 (anonymous namespace)::MoveItemToTrash()
#17 0x000058b634bd base::internal::Invoker<>::Run()
#18 0x000058b65744 gin_helper::Invoker<>::DispatchToCallback<>()
#19 0x000058c992d7 gin_helper::Dispatcher<>::DispatchToCallback()
#20 0x000059f18689 v8::internal::FunctionCallbackArguments::Call()
#21 0x000059f16f0e v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#22 0x000059f15068 v8::internal::Builtin_Impl_HandleApiCall()
#23 0x000059f14ad4 v8::internal::Builtin_HandleApiCall()
#24 0x00005b072d03 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit
#25 0x00005ae96c49 Builtins_InterpreterEntryTrampoline
#26 0x00005af53fd7 Builtins_AsyncFunctionAwaitResolveClosure
#27 0x00005b1d4ef6 Builtins_PromiseFulfillReactionJob
#28 0x00005af13ee3 Builtins_RunMicrotasks

[nornagon]

lmao of course it is. because there weren't any tests. sigh 🙃

[nornagon]

CI failures are flakes. Merging.

[release-clerk]

No Release Notes

[trop]

@niik has manually backported this PR to "9-x-y", please check out #25169

[trop]

@niik has manually backported this PR to "10-x-y", please check out #25170

[trop]

@niik has manually backported this PR to "11-x-y", please check out #25171