Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "fix: reply notifs sometimes destroyed too early" #25247

Merged
merged 2 commits into from Sep 2, 2020
Merged

revert: "fix: reply notifs sometimes destroyed too early" #25247

merged 2 commits into from Sep 2, 2020

Conversation

MarshallOfSound
Copy link
Member

Reverts #25086

Notes: Fixed issue where clicking notifications would no longer dismiss them as expected

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Sep 1, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
codebytere
codebytere approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background is that it transpires this conflicts with the HIG:

Clicking a notification when the Mac is unlocked dismisses the notification, removes it from Notification Center, opens the corresponding app, and shows related information.

@codebytere codebytere changed the title fix: Revert "fix: reply notifs sometimes destroyed too early" revert: "fix: reply notifs sometimes destroyed too early" Sep 1, 2020
@zcbenz zcbenz merged commit 184e72f into master Sep 2, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Fixed issue where clicking notifications would no longer dismiss them as expected

@zcbenz zcbenz deleted the revert-25086-fix-notifications-getting-lost branch September 2, 2020 01:02
@trop
Copy link
Contributor

trop bot commented Sep 2, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@MarshallOfSound MarshallOfSound mentioned this pull request Oct 21, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Oct 21, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #26084

@trop trop bot added the in-flight/8-x-y label Oct 21, 2020
@MarshallOfSound MarshallOfSound mentioned this pull request Oct 21, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Oct 21, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #26083

1 similar comment
@trop
Copy link
Contributor

trop bot commented Oct 21, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #26083

@trop trop bot added the in-flight/9-x-y label Oct 21, 2020
@MarshallOfSound MarshallOfSound mentioned this pull request Oct 21, 2020
Closed
@trop
Copy link
Contributor

trop bot commented Oct 21, 2020

@MarshallOfSound has manually backported this PR to "10-x-y", please check out #26082

MarshallOfSound added a commit that referenced this pull request Oct 23, 2020
@MarshallOfSound
revert: "fix: reply notifs sometimes destroyed too early" (#25247)
fb3ba19 
* Revert "fix: reply notifs sometimes destroyed too early (#25086)"

This reverts commit bea6c9e.

* nothing
@MarshallOfSound MarshallOfSound mentioned this pull request Oct 23, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Oct 23, 2020

@MarshallOfSound has manually backported this PR to "11-x-y", please check out #26131

MarshallOfSound added a commit that referenced this pull request Oct 23, 2020
@MarshallOfSound
revert: "fix: reply notifs sometimes destroyed too early" (#25247) (#…
d200b91 
…26131)

* Revert "fix: reply notifs sometimes destroyed too early (#25086)"

This reverts commit bea6c9e.

* nothing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @zcbenz @codebytere