fix: crash on nativeImage on Windows on ARM #25396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ckerr
approved these changes
Sep 9, 2020
MarshallOfSound
approved these changes
Sep 9, 2020
zcbenz
approved these changes
Sep 10, 2020
|
Release Notes Persisted
|
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I have automatically backported this PR to "11-x-y", please check out #25410 |
mlaurencin
pushed a commit
to mlaurencin/electron
that referenced
this pull request
Sep 16, 2020
* fix: nativeImage on WOA * Remove old ldflag * maybe this will work ¯\_(ツ)_/¯
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the crashes on WOA when using nativeImage. This issue was caused by this change:
https://source.chromium.org/chromium/chromium/src/+/master:build/config/win/BUILD.gn;l=100;bpv=1;bpt=0, so this PR reverts that change on WOA until the upstream issues https://bugs.chromium.org/p/chromium/issues/detail?id=1126549 and https://bugs.llvm.org/show_bug.cgi?id=47463 are resolved.
Fixes #25069
Checklist
npm testpassesRelease Notes
Notes: Fixed crashes using nativeImage on Windows on ARM.