Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use newer xCode image #25571

Merged
merged 2 commits into from Sep 22, 2020
Merged

build: use newer xCode image #25571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01c298
build: use newer xCode image
MarshallOfSound Sep 21, 2020
f140bfb
build: log changed file paths
MarshallOfSound Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -85,17 +85,17 @@ machine-linux-2xlarge: &machine-linux-2xlarge

machine-mac: &machine-mac
macos:
xcode: "11.5.0"
xcode: "12.2.0"

machine-mac-large: &machine-mac-large
resource_class: large
macos:
xcode: "11.5.0"
xcode: "12.2.0"

machine-mac-large-arm: &machine-mac-large-arm
resource_class: large
macos:
xcode: "12.0.0-large"
xcode: "12.2.0"

# Build configurations options.
env-testing-build: &env-testing-build
Expand Down
2 changes: 2 additions & 0 deletions script/doc-only-change.js
View file
Open in desktop
Expand Up @@ -34,6 +34,8 @@ async function checkIfDocOnlyChange () {
owner: 'electron', repo: 'electron', pull_number: pullRequestNumber
});

console.log('Changed Files:', filesChanged.data.map(fileInfo => fileInfo.filename));

const nonDocChange = filesChanged.data.find((fileInfo) => {
const fileDirs = fileInfo.filename.split('/');
if (fileDirs[0] !== 'docs') {
Expand Down