chore: remove custom Node.js debugger #25587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes our custom Node.js debugger and related patches. When we have
nodeIntegration
enabled in the renderer process, Blink creates the V8 inspector themselves, so that means two of them will be created, leading to a fun set of crashes. This PR adjusts a patch to ensure no inspector is created in the renderer process.This PR also has the side effect of making the
--inspect-brk-node
flag work again 馃帀Checklist
npm test
passesRelease Notes
Notes: none