Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tsify net-log #25670

Merged
merged 3 commits into from Sep 29, 2020
Merged

chore: tsify net-log #25670

merged 3 commits into from Sep 29, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 28, 2020 •
edited by nornagon

Backport of #24322

See that PR for details.

Fixes #25669

Notes: Fixed an issue where netLog.startLogging and netLog.stopLogging were undefined.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@trop trop bot requested a review from nornagon September 28, 2020 18:16
@trop trop bot mentioned this pull request Sep 28, 2020
Merged
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@jkleinsc jkleinsc merged commit de0ddd5 into 10-x-y Sep 29, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 29, 2020

Release Notes Persisted

Fixed an issue where netLog.startLogging and netLog.stopLogging were undefined.

@jkleinsc jkleinsc deleted the trop/10-x-y-bp-chore-tsify-net-log-1601317003684 branch September 29, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @jkleinsc @nornagon