build: rename the v8 context snapshot on arm64 macOS builds #26086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Oct 21, 2020
codebytere
approved these changes
Oct 21, 2020
zcbenz
previously requested changes
Oct 26, 2020
|
Looks like this is gonna land upstream, updated the patch to exactly match upstream |
|
No Release Notes |
|
I have automatically backported this PR to "11-x-y", please check out #26202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the patch description, in order to generate universal builds on macOS both the arm64 and x64 snapshots need to be available, this is only possible if they have unique filenames. This adds a patch which I intend to upstream to Chromium to make this the default behavior (and make the filename powered by GN instead of being hardcoded everywhere).
Upstream attempt: https://chromium-review.googlesource.com/c/chromium/src/+/2490980
Notes: no-notes