feat: add support for DOM elements going over the context bridge #26776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
requested changes
Dec 1, 2020
MarshallOfSound
force-pushed
the
bridge-dom
branch
from
c20b832
to
a5f69ec
Compare
|
@nornagon Docs updated, tests go both ways 👍 |
MarshallOfSound
force-pushed
the
bridge-dom
branch
from
a5f69ec
to
93a55b7
Compare
MarshallOfSound
added
semver/minor
nornagon
reviewed
Dec 7, 2020
docs/api/context-bridge.md
Outdated
| @@ -106,6 +106,7 @@ has been included below for completeness: | |||
| | `Promise` | Complex | ✅ | ✅ | Promises are only proxied if they are the return value or exact parameter. Promises nested in arrays or objects will be dropped. | | |||
| | `Function` | Complex | ✅ | ✅ | Prototype modifications are dropped. Sending classes or constructors will not work. | | |||
| | [Cloneable Types](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm) | Simple | ✅ | ✅ | See the linked document on cloneable types | | |||
| | `HTMLElement` | Complex | ✅ | ✅ | Prototype modifications are dropped. Sending custom elements will not work. | | |||
There was a problem hiding this comment.
I believe this is incorrect, as this supports Element not just HTMLElement. e.g. SVGElement is a child class of Element but not HTMLElement.
Further—should/can we support Node here, so we can additionally pass references to text nodes?
There was a problem hiding this comment.
@nornagon The "FromV8" part of this comes from WebElement and the "ToV8" comes from WebNode. So I think that means we can't support Node's 🤔
nornagon
approved these changes
Dec 7, 2020
miniak
approved these changes
Dec 8, 2020
codebytere
added
semver/minor
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
codebytere
approved these changes
Dec 10, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title and as in notes, uses blink APIs to safely transfer a WebElement reference from one context to another
Notes: Added support for passing DOM elements over the context bridge