Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add eyedropper tool functionality to browser view #27275

Merged
merged 8 commits into from
Jan 21, 2021

Conversation

mlaurencin
Copy link
Contributor

@mlaurencin mlaurencin commented Jan 11, 2021

Description of Change

Closes #26883

This PR adds the functionality of the Chromium eyedropper when using the color picker tool. Previously when you clicked on the eyedropper from the color picker nothing would happen. The eyedropper now works as expected, as colors in the window can be selected.

There is a known issue (reported here) in Chromium where, in a multiple monitor setup, the tool may function incorrectly if the main monitor is not positioned in the upper left corner.

Fiddle: https://gist.github.com/mlaurencin/cb0f0b2d6b075e67721c41474c0f17da

Examples:

Eyedropper test final image

(Be aware that the color palette is not rendered in the screen capture, but was displayed like in the above image)

smaller.eyedropper.mp4

Checklist

Release Notes

Notes: None

@mlaurencin mlaurencin requested review from codebytere and a team January 11, 2021 23:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 11, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 18, 2021
@mlaurencin mlaurencin changed the title [WIP] fix: add eyedropper tool functionality to browser view fix: add eyedropper tool functionality to browser view Jan 20, 2021
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jan 21, 2021
@codebytere codebytere marked this pull request as ready for review January 21, 2021 17:28
@codebytere codebytere merged commit 4f930b6 into master Jan 21, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 21, 2021

Release Notes Persisted

None

@codebytere codebytere deleted the eyedropper-fix branch January 21, 2021 21:02
@trop
Copy link
Contributor

trop bot commented Jan 21, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 21, 2021

I have automatically backported this PR to "12-x-y", please check out #27442

@trop
Copy link
Contributor

trop bot commented Jan 27, 2021

@miniak has manually backported this PR to "11-x-y", please check out #27509

@trop
Copy link
Contributor

trop bot commented Jan 27, 2021

@miniak has manually backported this PR to "10-x-y", please check out #27515

zcbenz pushed a commit that referenced this pull request Jan 27, 2021
Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eyedropper does not work
4 participants