chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d #27475

NB: this is mooted by @nornagon's suggestion of buffering these messages in mojo, which IMO should be Plan A. I wrote the items below after seeeing that 🙂

The new service_ member field only remembers the last-opened RenderFrame's service and so it's possible that pre-create messages will never get pumped in the current implementation if more than one RenderFrame is created.

There's also a possibility of messages being processed out-of-order ElectronApiServiceImpl::DidCreateDocumentElement() is called before RendererClientBase::RunScriptsAtDocumentStart() due to how ElectronApiServiceImpl::document_created_ is used. Possibly ProcessPendingMessages() should be made private and called by ElectronApiServiceImpl::DidCreateDocumentElement() -- this would also remove the need for the new service_ field, preventing the previous paragraph's potential pitfall

shell/renderer/electron_api_service_impl.h

This reverts commit 8fd3aae.

nornagon

lgtm on behalf of @codebytere

release-clerk · 2021-02-09T20:16:25Z

No Release Notes

codebytere requested a review from a team as a code owner January 25, 2021 16:53

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 25, 2021

codebytere added the semver/patch backwards-compatible bug fixes label Jan 25, 2021

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 26, 2021

codebytere mentioned this pull request Jan 27, 2021

Allow roller to update a PR opened by someone other than electron-bot electron/roller#58

Closed

codebytere force-pushed the roller/chromium/master branch from 63162f7 to 2fa2f1a Compare January 27, 2021 19:42

deepak1556 self-assigned this Jan 28, 2021

deepak1556 added the roller/pause label Jan 28, 2021

codebytere and others added 22 commits January 28, 2021 15:32

chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d

49c50cf

2628767: Move Impression struct from content to blink

17b7b55

https://chromium-review.googlesource.com/c/chromium/src/+/2628767

chore: roll DEPS to 1f252b391a40e2681b0d9aff6497b7401863d1fc

8fa0515

chore: update patches

6cbfb24

[printing] Clean up files related to legacy IPCs

98c6584

https://chromium-review.googlesource.com/c/chromium/src/+/2648993

[Extensions] s/SharedUserScriptManager/ExtensionUserScriptManager

61a66ac

https://chromium-review.googlesource.com/c/chromium/src/+/2639867

Remove MimeHandlerViewContainer, ExtensionGuestViewContainer.

292ef54

https://chromium-review.googlesource.com/c/chromium/src/+/2635797

Move MenuItem struct to blink

f670146

https://chromium-review.googlesource.com/c/chromium/src/+/2631518

Move UntrustworthyContextMenuParams struct to blink

502df7d

https://chromium-review.googlesource.com/c/chromium/src/+/2636738

WebUI cleanup: Remove unnecessary prefixes in grit() target names.

7e6349f

https://chromium-review.googlesource.com/c/chromium/src/+/2639803

Change OverrideWebkitPrefs() param to WebContents.

d62a68b

https://chromium-review.googlesource.com/c/chromium/src/+/2626355

Deprecate blink::mojom::ResourceType in PluginResponseInterceptorURLL…

2ae427a

…oaderThrottle https://chromium-review.googlesource.com/c/chromium/src/+/2637121

Cleanup SaveEditedPDFForm feature flag

a12325a

https://chromium-review.googlesource.com/c/chromium/src/+/2643267

[Bluetooth]Navigate users to preferences when macOS permission denied

29ad921

https://chromium-review.googlesource.com/c/chromium/src/+/2617129

Move UntrustworthyContextMenuParams struct to blink

ff613da

https://chromium-review.googlesource.com/c/chromium/src/+/2636738

Convert blink::ContextMenuDataInputFieldType enum to Mojo

df86501

https://chromium-review.googlesource.com/c/chromium/src/+/2636736

[printing] Convert printing preview IPCs to mojo

0d64dcf

https://chromium-review.googlesource.com/c/chromium/src/+/2624271 https://chromium-review.googlesource.com/c/chromium/src/+/2632023

[mparch] NavigationController owned by Navigator

3ee24be

https://chromium-review.googlesource.com/c/chromium/src/+/2626654

ForEachObserver -> NotifyObservers to save binary size

09aaaab

https://chromium-review.googlesource.com/c/chromium/src/+/2639396

chore: update patches

9272632

System Media Controls: Use SMC directly in MediaKeysListenerManager

7b01fef

https://chromium-review.googlesource.com/c/chromium/src/+/2606785

WebUI cleanup: Remove unnecessary prefixes in grit() target names.

d63c816

https://chromium-review.googlesource.com/c/chromium/src/+/2639803

jkleinsc reviewed Feb 4, 2021

View reviewed changes

shell/browser/lib/bluetooth_chooser.cc Show resolved Hide resolved

jkleinsc approved these changes Feb 4, 2021

View reviewed changes

codebytere requested a review from deepak1556 February 4, 2021 17:42

nornagon reviewed Feb 4, 2021

View reviewed changes

shell/renderer/electron_api_service_impl.cc Outdated Show resolved Hide resolved

nornagon reviewed Feb 4, 2021

View reviewed changes

shell/browser/electron_browser_context.cc Show resolved Hide resolved

nornagon requested changes Feb 4, 2021

View reviewed changes

ckerr reviewed Feb 4, 2021

View reviewed changes

shell/renderer/electron_api_service_impl.h Outdated Show resolved Hide resolved

codebytere and others added 4 commits February 4, 2021 13:41

Fixup message passing

4986d23

make the renderer-side electron api interface not associated

9f6b53f

fix takeHeapSnapshot

8fb8f6f

queue messages until frame is created

9884aee

nornagon force-pushed the roller/chromium/master branch from c02705d to 9884aee Compare February 8, 2021 19:08

nornagon and others added 11 commits February 8, 2021 11:57

simplify NotifyUserActivation using existing blink mojo method

81a83e5

guard takeHeapSnapshot against early usage

61d1dbe

fix: early GC of WebFrameMain instances (#27648)

57d2cd9

use WebFrameMain to send ipcs

b891b67

sendTo goes through WebFrameMain

0861ae5

bind netlog cleanup to weak ptr

3a6bf38

put NotifyUserActivation call after weak_this check

7909e6f

remove vestigal PendingElectronApiServiceMessage class

882650f

inline SendIPCMessageWithSender, as it is only used once

5950bc9

DCHECK instead of if() in SetCorsOriginAccessListForOrigin

8fd3aae

Revert "DCHECK instead of if() in SetCorsOriginAccessListForOrigin"

d6200d0

This reverts commit 8fd3aae.

nornagon approved these changes Feb 9, 2021

View reviewed changes

nornagon merged commit e46446e into master Feb 9, 2021

nornagon deleted the roller/chromium/master branch February 9, 2021 20:16

samuelmaddock mentioned this pull request Feb 10, 2021

refactor: WebContents.send -> mainFrame.send #27670

Closed

2 tasks

codebytere mentioned this pull request Aug 16, 2021

fix: media key globalShortcuts on macOS #30552

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d #27475

chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d #27475

codebytere commented Jan 25, 2021 •

edited

nornagon left a comment

ckerr left a comment

nornagon left a comment

release-clerk bot commented Feb 9, 2021

chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d #27475

chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d #27475

Conversation

codebytere commented Jan 25, 2021 • edited

nornagon left a comment

Choose a reason for hiding this comment

ckerr left a comment

Choose a reason for hiding this comment

nornagon left a comment

Choose a reason for hiding this comment

release-clerk bot commented Feb 9, 2021

codebytere commented Jan 25, 2021 •

edited