Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: patch libuv to use posix_spawn on macOS (#27026) #27810

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 18, 2021

Backport of #27797

See that PR for details.

Notes: Reverted posix_spawn change in libuv that affected child process spawning on macOS Big Sur.

@trop trop bot requested a review from a team as a code owner February 18, 2021 23:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2021
@trop trop bot requested a review from VerteDinde February 18, 2021 23:36
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failures are known flakes unrelated to this PR.

@jkleinsc jkleinsc merged commit a859436 into 12-x-y Feb 22, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 22, 2021

Release Notes Persisted

Reverted posix_spawn change in libuv that affected child process spawning on macOS Big Sur.

@trop trop bot deleted the trop/12-x-y-bp-revert-patch-libuv-to-use-posix_spawn-on-macos-27026--1613691403027 branch February 22, 2021 15:06
timsu pushed a commit to cryptagon/electron that referenced this pull request May 13, 2021
dreamerns pushed a commit to cryptagon/electron that referenced this pull request Aug 17, 2021
dreamerns pushed a commit to cryptagon/electron that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants