chore: Add a condition to crashReporter deprecate log #27953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When developer set submitURL to '' crash reports will be saved at `...\AppData\Roaming\...\Crashpad\reports`, will not be uploaded to the server.
So at this time `deprecate.log('Sending uncompressed crash reports....')` is unnecessary.
xland
changed the title
|
@xland can you please fix linting? |
nornagon
reviewed
Mar 2, 2021
change to check uploadToServer Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
zcbenz
approved these changes
Mar 4, 2021
|
No Release Notes |
This was referenced Mar 5, 2021
|
I have automatically backported this PR to "11-x-y", please check out #28012 |
|
I have automatically backported this PR to "12-x-y", please check out #28013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developer set submitURL to '' crash reports will be saved at
...\AppData\Roaming\...\Crashpad\reports, will not be uploaded to the server.So at this time
deprecate.log('Sending uncompressed crash reports....')is unnecessary.Description of Change
Checklist
npm testpassesRelease Notes
Notes: none.