Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a condition to crashReporter deprecate log #28012

Merged
merged 2 commits into from
Mar 7, 2021
Merged

chore: Add a condition to crashReporter deprecate log #28012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c2f1ea
Add a condition to crashReporter deprecate log
xland Mar 2, 2021
f20fe2e
Update lib/browser/api/crash-reporter.ts
xland Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/browser/api/crash-reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class CrashReporter {

if (submitURL == null) throw new Error('submitURL is a required option to crashReporter.start');

if (!compress) {
if (!compress && uploadToServer) {
deprecate.log('Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.');
}

Expand Down