Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1fe571a from node #28110

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 10, 2021

Backport of #28067

See that PR for details.

Notes: fix native module compilation with AsyncCleanupHooks on windows

@trop trop bot requested a review from a team as a code owner March 10, 2021 19:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 10, 2021
@trop trop bot requested a review from deepak1556 March 10, 2021 19:45
@trop trop bot mentioned this pull request Mar 10, 2021
5 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 10, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 10, 2021
@zcbenz zcbenz merged commit a1b46ef into 13-x-y Mar 15, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 15, 2021

Release Notes Persisted

fix native module compilation with AsyncCleanupHooks on windows

@trop trop bot deleted the trop/13-x-y-bp-chore-cherry-pick-1fe571a-from-node-1615405487557 branch March 15, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants