fix: bad menu position when no positioning item specified #28224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Mar 16, 2021
zcbenz
approved these changes
Mar 18, 2021
codebytere
approved these changes
Mar 18, 2021
|
Release Notes Persisted
|
This was referenced Mar 18, 2021
|
I have automatically backported this PR to "13-x-y", please check out #28276 |
|
I have automatically backported this PR to "12-x-y", please check out #28277 |
|
I have automatically backported this PR to "11-x-y", please check out #28278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #13279.
This looks like it was a typo. When
positioning_itemisn't specified, it's-1, which evaluates totrue, so this block wouldn't be invoked.I've tested manually and it seems to fix the behavior described in the bug.
Checklist
npm testpassesRelease Notes
Notes: Fixed context menus not being positioned correctly when near the edge of the screen.