Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick 00245033cf from v8 #28903

Merged
merged 1 commit into from Apr 28, 2021
Merged

chore: cherry-pick 00245033cf from v8 #28903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/v8/.patches
View file
Open in desktop
Expand Up @@ -32,3 +32,4 @@ lts-m86_builtins_fix_array_prototype_concat_with_species.patch
lts-m86_builtins_harden_array_prototype_concat.patch
merged_squashed_multiple_commits.patch
merged_compiler_fix_a_bug_in_visitspeculativeintegeradditiveop.patch
m86-lts_compiler_fix_off-by-one_error_in_kadditivesafeinteger.patch
37 changes: 37 additions & 0 deletions patches/v8/m86-lts_compiler_fix_off-by-one_error_in_kadditivesafeinteger.patch
View file
Open in desktop
@@ -0,0 +1,37 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Georg Neis <neis@chromium.org>
Date: Mon, 19 Apr 2021 13:12:46 +0200
Subject: M86-LTS: [compiler] Fix off-by-one error in kAdditiveSafeInteger

(cherry picked from commit 798fbcb0a3e5a292fb775c37c19d9fe73bbac17c)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Bug: chromium:1198705
Change-Id: I6b3ad82754e1ca72701ce57f16c4f085f8c87f77
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835705
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#74033}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850708
Commit-Queue: Artem Sumaneev <asumaneev@google.com>
Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
Cr-Commit-Position: refs/branch-heads/8.6@{#87}
Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

diff --git a/src/compiler/type-cache.h b/src/compiler/type-cache.h
index b71ea8455d544daccca1ef530bbb7dc735d0df09..54e725c64f7e359df3fd930c06fa59c5f17c95bd 100644
--- a/src/compiler/type-cache.h
+++ b/src/compiler/type-cache.h
@@ -80,7 +80,7 @@ class V8_EXPORT_PRIVATE TypeCache final {
Type::Union(kPositiveIntegerOrMinusZero, Type::NaN(), zone());

Type const kAdditiveSafeInteger =
- CreateRange(-4503599627370496.0, 4503599627370496.0);
+ CreateRange(-4503599627370495.0, 4503599627370495.0);
Type const kSafeInteger = CreateRange(-kMaxSafeInteger, kMaxSafeInteger);
Type const kAdditiveSafeIntegerOrMinusZero =
Type::Union(kAdditiveSafeInteger, Type::MinusZero(), zone());