Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide no-op implementation of app.setUserModelId #28921

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 29, 2021

Backport of #28915

See that PR for details.

Notes: Restored cross-platform noop implementation of app.setAppUserModelId

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2021
@trop trop bot requested a review from MarshallOfSound April 29, 2021 01:41
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 29, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2021
@codebytere codebytere merged commit 87d3530 into 13-x-y Apr 29, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 29, 2021

Release Notes Persisted

Restored cross-platform noop implementation of app.setAppUserModelId

@trop trop bot deleted the trop/13-x-y-bp-fix-provide-no-op-implementation-of-app-setusermodelid-1619660481141 branch April 29, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants