Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f37149c4434f from chromium #28949

Merged
merged 2 commits into from Apr 30, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 30, 2021

[Autofill] Don't show autofill dropdown for element outside the viewport

Details are in the linked bug.

Also cherry pick crrev/c/2682341 and a part of crrev/c/2628287 to fix
failing tests and compile errors.

(cherry picked from commit 53a4f38ee5d44bd935d176cc89e3e59fd0a3970e)

Bug: 1172533,1173297
Change-Id: Iee429cac167ccdb0cd74acf57fc5f7c3821883b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675932
Commit-Queue: Mohamed Amir Yosef mamir@chromium.org
Reviewed-by: Vasilii Sukhanov vasilii@chromium.org
Reviewed-by: Evan Stade estade@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#851718}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822155
Commit-Queue: Jana Grill janagrill@google.com
Reviewed-by: Achuith Bhandarkar achuith@chromium.org
Reviewed-by: Victor-Gabriel Savu vsavu@google.com
Owners-Override: Achuith Bhandarkar achuith@chromium.org
Cr-Commit-Position: refs/branch-heads/4240@{#1611}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}

Notes: Security: backported fix for CVE-2021-21215 and CVE-2021-21216

@ppontes ppontes requested a review from a team as a code owner April 30, 2021 11:15
@ppontes ppontes added 10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Apr 30, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 30, 2021
@MarshallOfSound MarshallOfSound merged commit 770fff6 into 10-x-y Apr 30, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 30, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-21215 and CVE-2021-21216

@MarshallOfSound MarshallOfSound deleted the cherry-pick/10-x-y/chromium/f37149c4434f branch February 8, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants