Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow Node.js to manage microtasks queue #28974

Merged
merged 2 commits into from
May 3, 2021
Merged

fix: allow Node.js to manage microtasks queue #28974

merged 2 commits into from
May 3, 2021

Commits on May 3, 2021

  1. fix: allow Node.js to manage microtasks queue 

    When `uv_run()` resulted in invocation of JS functions the microtask
queue checkpoint in Node's CallbackScope was a no-op because the
expected microtask queue policy was `kExplicit` and Electron ran under
`kScoped` policy. This change switches policy to `kExplicit` right
before `uv_run()` and reverts it back to original value after `uv_run()`
completes to provide better compatibility with Node.
    @indutny @electron-bot
    indutny authored and electron-bot committed May 3, 2021
    Configuration menu
    Copy the full SHA
    aede948 View commit details
    Browse the repository at this point in the history

  2. add comment

    @indutny @electron-bot
    indutny authored and electron-bot committed May 3, 2021
    Configuration menu
    Copy the full SHA
    3cb182a View commit details
    Browse the repository at this point in the history