chore: cherry-pick 7abc7e45b2 from node #29047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
5 tasks
trop
bot
added
12-x-y
backport
|
I believe the cherry-pick didn't work well in the case of this PR. There are extra lines in the |
indutny
reviewed
May 6, 2021
codebytere
force-pushed
the
trop/12-x-y-bp-chore-cherry-pick-7abc7e45b2-from-node-1620313477600
branch
from
37c5a19
to
481c4ec
Compare
|
@deepak1556 @zcbenz sorry for an extra ping, but it'd mean a lot for me if this could go into the next 12-x-y release. Would appreciate a review. Thanks! |
codebytere
approved these changes
May 6, 2021
|
Release Notes Persisted
|
MarshallOfSound
deleted the
trop/12-x-y-bp-chore-cherry-pick-7abc7e45b2-from-node-1620313477600
branch
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29021
See that PR for details.
Notes: Improved performance of
napi_threadsafe_function