-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: modernize protocol-handler docs #29380
Conversation
docs/fiddles/system/protocol-handler/launch-app-from-URL-in-another-app/index.html
Outdated
Show resolved
Hide resolved
docs/fiddles/system/protocol-handler/launch-app-from-URL-in-another-app/main.js
Outdated
Show resolved
Hide resolved
docs/fiddles/system/protocol-handler/launch-app-from-URL-in-another-app/main.js
Outdated
Show resolved
Hide resolved
docs/fiddles/system/protocol-handler/launch-app-from-URL-in-another-app/preload.js
Outdated
Show resolved
Hide resolved
docs/fiddles/system/protocol-handler/launch-app-from-URL-in-another-app/index.html
Show resolved
Hide resolved
Release Notes Persisted
|
I have automatically backported this PR to "12-x-y", please check out #30056 |
I have automatically backported this PR to "13-x-y", please check out #30057 |
I have automatically backported this PR to "14-x-y", please check out #30058 |
* docs: modernize protocol-handler docs * docs: iadd contextIsolation * docs: add guide for launch-app-from-URL-in-other-app * docs: address comments * chore: fix brackets * chore: add escaped brackets
I looked into the history of this file, after running into issues with the example. This PR's description / commit doesn't match the changes performed.... "Changed docs to use protocol.registerFileProtocol rather than app.setAsDefaultProtocol and removed legacy code from the index.html file." The final copy, as committed when squashed, does not reference protocol.registerFileProtocol at all. Frankly as someone who has volunteered time and effort to open source in the past, this confuses me greatly that this has happened, and as a new user to electron it's not been very smooth despite the seemingly abundant docs. |
Description of Change
Changed docs to use
protocol.registerFileProtocol
rather thanapp.setAsDefaultProtocol
and removed legacy code from the index.html file.Checklist
npm test
passesRelease Notes
Notes: update protocol-handler docs to use
protocol.registerFileProtocol