Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: publish-to-npm respects main #29406

Merged
merged 2 commits into from May 31, 2021
Merged

refactor: publish-to-npm respects main #29406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3049e1a
refactor: publish-to-npm respects main
nornagon May 27, 2021
c71723d
Update script/release/publish-to-npm.js
nornagon May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions script/release/publish-to-npm.js
View file
Open in desktop
Expand Up @@ -111,8 +111,9 @@ new Promise((resolve, reject) => {
const currentBranch = await getCurrentBranch();

if (release.tag_name.indexOf('nightly') > 0) {
if (currentBranch === 'master') {
// Nightlies get published to their own module, so master nightlies should be tagged as latest
// TODO(main-migration): Simplify once main branch is renamed.
if (currentBranch === 'master' || currentBranch === 'main') {
// Nightlies get published to their own module, so they should be tagged as latest
npmTag = 'latest';
} else {
npmTag = `nightly-${currentBranch}`;
Expand All @@ -127,10 +128,10 @@ new Promise((resolve, reject) => {
JSON.stringify(currentJson, null, 2)
);
} else {
if (currentBranch === 'master') {
// This should never happen, master releases should be nightly releases
if (currentBranch === 'master' || currentBranch === 'main') {
// This should never happen, main releases should be nightly releases
// this is here just-in-case
npmTag = 'master';
throw new Error('Unreachable release phase, can\'t tag a non-nightly release on the main branch');
} else if (!release.prerelease) {
// Tag the release with a `2-0-x` style tag
npmTag = currentBranch;
Expand Down