Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep shifted character in menu accelerator #29481

Merged
merged 4 commits into from
Jun 3, 2021
Merged

fix: keep shifted character in menu accelerator #29481

merged 4 commits into from
Jun 3, 2021

Commits on Jun 2, 2021

  1. fix: correctly handle shifted char in accelerator

    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f4ae5fa View commit details
    Browse the repository at this point in the history

  2. test: use actual accelerator of NSMenuItem

    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    32b5916 View commit details
    Browse the repository at this point in the history

  3. chore: simplify KeyboardCodeFromStr

    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    172c5fa View commit details
    Browse the repository at this point in the history

  4. chore: GetAcceleratorTextAt is testing only

    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e374724 View commit details
    Browse the repository at this point in the history