Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use PathProvider for user-data-dir and others #29649

Merged
merged 7 commits into from Jun 15, 2021
Merged

refactor: use PathProvider for user-data-dir and others #29649

merged 7 commits into from Jun 15, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jun 11, 2021 •
edited

Description of Change

This extracts just the PathProvider refactor from #25089, for separate review.

Also fixes #29340.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: Fixed app.getPath('logs') returning the wrong path on Linux and Windows.

@nornagon nornagon added no-backport semver/patch backwards-compatible bug fixes labels Jun 11, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 11, 2021
@nornagon
Copy link
Member Author

target/14-x-y because #25089 is too, and that depends on this.

@nornagon
Copy link
Member Author

Possibly fixes #28701 as well?

deepak1556
deepak1556 approved these changes Jun 12, 2021
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with build failures addressed.

shell/app/electron_main_delegate.cc Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2021
zcbenz
zcbenz approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with above comments addressed.

@zcbenz zcbenz merged commit ebf54d7 into main Jun 15, 2021
@zcbenz zcbenz deleted the refactor-paths branch June 15, 2021 00:32
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2021

Release Notes Persisted

Fixed app.getPath('logs') returning the wrong path on Linux and Windows.

@trop
Copy link
Contributor

trop bot commented Jun 15, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

This was referenced Jun 22, 2021
Closed
Merged
@trop
Copy link
Contributor

trop bot commented Jun 23, 2021

@nornagon has manually backported this PR to "14-x-y", please check out #29865

nornagon added a commit that referenced this pull request Jun 23, 2021
@nornagon
refactor: use PathProvider for user-data-dir and others (#29649)
467fe76
nornagon added a commit that referenced this pull request Jun 23, 2021
@nornagon
refactor: use PathProvider for user-data-dir and others (#29649) (#29865
d79d073 
)
This was referenced Jul 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: app.getPath('logs') points to the wrong directory
3 participants
@nornagon @zcbenz @deepak1556