Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable CET as v8 deoptimization is incompatible with it #29688

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 14, 2021

Backport of #29546

See that PR for details.

Notes: Fixed crashes on latest gen Intel and Ryzen processors

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2021
@trop trop bot requested a review from MarshallOfSound June 14, 2021 19:21
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2021
@MarshallOfSound MarshallOfSound merged commit 5e3bdfd into 14-x-y Jun 16, 2021
@MarshallOfSound MarshallOfSound deleted the trop/14-x-y-bp-fix-disable-cet-as-v8-deoptimization-is-incompatible-with-it-1623698504861 branch June 16, 2021 16:57
@release-clerk
Copy link

release-clerk bot commented Jun 16, 2021

Release Notes Persisted

Fixed crashes on latest gen Intel and Ryzen processors

@vladimiry
Copy link

Thanks for moving it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants