Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix frontmatter for Tray tutorial #29788

Merged
merged 1 commit into from
Jun 21, 2021
Merged

docs: fix frontmatter for Tray tutorial #29788

merged 1 commit into from
Jun 21, 2021

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jun 18, 2021 •
edited

Description of Change

Fixing a little mishap with the formatting slipped through the previous PR. Without this whitespace fix, Markdown parsers won't correctly detect the frontmatter.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 18, 2021
@erickzhao erickzhao mentioned this pull request Jun 18, 2021
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2021
@zcbenz zcbenz merged commit aca14bf into electron:main Jun 21, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 21, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jun 21, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jun 21, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jun 21, 2021

I have automatically backported this PR to "13-x-y", please check out #29803

erickzhao added a commit to erickzhao/ericktron that referenced this pull request Jun 30, 2021
@erickzhao
docs: fix frontmatter for Tray tutorial (electron#29788)
ae2622a
@erickzhao erickzhao mentioned this pull request Jun 30, 2021
Merged
@erickzhao erickzhao deleted the patch-5 branch June 30, 2021 19:13
zcbenz pushed a commit that referenced this pull request Jul 4, 2021
@erickzhao @georgexu99
docs: added guide and updated docs for Tray (#29964)
d27adae 
* docs: added guide and updated docs for Tray (#29385) (#29762)

* docs: added guide and updated docs for Tray

* docs: improve clarity

* docs: fix frontmatter for Tray tutorial (#29788)

Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com>
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@erickzhao @BlackHole1
docs: fix frontmatter for Tray tutorial (electron#29788)
794d6bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erickzhao @nornagon @zcbenz