Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set python interpreter to python3 in script/spec-runner.js #29944

Merged
merged 1 commit into from
Jul 1, 2021
Merged

chore: set python interpreter to python3 in script/spec-runner.js #29944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ executors:
type: enum
enum: ["medium", "xlarge", "2xlarge+"]
docker:
- image: electron.azurecr.io/build:6555a80939fb4c3ddf9343b3f140e573f40de225
- image: electron.azurecr.io/build:4fc81b50f9c0980699d329bc32062fac20a26701
resource_class: << parameters.size >>

macos:
Expand Down
4 changes: 2 additions & 2 deletions script/spec-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ async function runRemoteBasedElectronTests () {
const runnerArgs = ['electron/spec', ...unknownArgs.slice(2)];
if (process.platform === 'linux') {
runnerArgs.unshift(path.resolve(__dirname, 'dbus_mock.py'), exe);
exe = 'python';
exe = 'python3';
}

const { status } = childProcess.spawnSync(exe, runnerArgs, {
Expand Down Expand Up @@ -199,7 +199,7 @@ async function runMainProcessElectronTests () {
const runnerArgs = ['electron/spec-main', ...unknownArgs.slice(2)];
if (process.platform === 'linux') {
runnerArgs.unshift(path.resolve(__dirname, 'dbus_mock.py'), exe);
exe = 'python';
exe = 'python3';
}

const { status, signal } = childProcess.spawnSync(exe, runnerArgs, {
Expand Down
2 changes: 1 addition & 1 deletion vsts-arm32v7.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
containers:
- container: arm32v7-test-container
image: electron.azurecr.io/build:arm32v7-6555a80939fb4c3ddf9343b3f140e573f40de225
image: electron.azurecr.io/build:arm32v7-4fc81b50f9c0980699d329bc32062fac20a26701
options: --shm-size 128m

jobs:
Expand Down
2 changes: 1 addition & 1 deletion vsts-arm64v8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
containers:
- container: arm64v8-test-container
image: electron.azurecr.io/build:arm64v8-6555a80939fb4c3ddf9343b3f140e573f40de225
image: electron.azurecr.io/arm64v8-4fc81b50f9c0980699d329bc32062fac20a26701
options: --shm-size 128m

jobs:
Expand Down