Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create documentation for browser api #30071

Merged
merged 2 commits into from Jul 28, 2021
Merged

docs: create documentation for browser api #30071

merged 2 commits into from Jul 28, 2021

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Jul 10, 2021 •
edited

Description of Change

Added a tutorial detailing how to make an Electron API within the Browser Module.

Checklist

Release Notes

Notes: add tutorial for Electron Browser API additions

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 10, 2021
@georgexu99 georgexu99 marked this pull request as ready for review July 14, 2021 00:10
@VerteDinde VerteDinde self-requested a review July 14, 2021 00:25
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 17, 2021
VerteDinde
VerteDinde approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for taking the time to write this up

@VerteDinde VerteDinde merged commit bd85b1d into electron:main Jul 28, 2021
1 check passed
@release-clerk
Copy link

release-clerk bot commented Jul 28, 2021

Release Notes Persisted

add tutorial for Electron Browser API additions

@georgexu99 georgexu99 deleted the createApiDocs branch July 29, 2021 16:06
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@georgexu99 @BlackHole1
docs: create documentation for browser api (electron#30071)
ebbf9a0 
* docs: create documentation for browser api

* docs: add cpp theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
documentation 📓 no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgexu99 @VerteDinde @dsanders11