Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 5487040a284a from chromium #30203

Merged
merged 3 commits into from Jul 22, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jul 19, 2021

Closes #30173.

Don't TexImage via GPU when OOP raster is disabled on Windows.

For some reason it's much slower than the the non-GPU based path. The
test page https://koush.github.io/webcodecs/ goes from ~270fps decoding
and ~5fps rendering to ~300fps decoding and >> 60fps rendering when
running with --disable-oop-rasterization.

R=kbr

Bug: 1227921
Change-Id: I1abbcfd5c4a515540753c8c5e681949f6f236c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018801
Commit-Queue: Dale Curtis dalecurtis@chromium.org
Reviewed-by: Kenneth Russell kbr@chromium.org
Cr-Commit-Position: refs/heads/master@{#900587}

Closes #30173.

Notes: Backported fix for https://crbug.com/1227921.

@nornagon nornagon requested a review from a team as a code owner July 19, 2021 21:18
@nornagon nornagon added 13-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jul 19, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 19, 2021
@koush
Copy link

koush commented Jul 21, 2021

Seem to be spurious/unrelated failures? Let me know if there's anything you need for me regarding this change.

@nornagon nornagon merged commit 64c6737 into 13-x-y Jul 22, 2021
@nornagon nornagon deleted the cherry-pick/13-x-y/chromium/5487040a284a branch July 22, 2021 17:14
@release-clerk
Copy link

release-clerk bot commented Jul 22, 2021

Release Notes Persisted

Backported fix for https://crbug.com/1227921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants