Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): OpenURI portal support for shell.showItemInFolder() #30716

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3009959.

Adds OpenURI portal support for shell.showItemInFolder().

The OpenURI portal is a more universal standard for being able to open
various items on the host, including directories. More critically, it
has special handling for containerized runtimes that will remap special
paths to point to the proper host locations.

Use the OpenURI portal as a fallback for
if the FileManager1 API is not available. When running in a
containerized runtime, D-Bus access is generally sandboxed, so Chromium
will notice that FileManager1 is not accessible and use the portal.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Aug 26, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 26, 2021
@codebytere codebytere changed the title fix(linux): OpenURI portal support for shell.showItemInFolder() fix(linux): OpenURI portal support for shell.showItemInFolder() Aug 26, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2021
@zcbenz zcbenz merged commit 63b3540 into main Sep 1, 2021
@zcbenz zcbenz deleted the add-openuri-portal-support branch September 1, 2021 01:04
@release-clerk
Copy link

release-clerk bot commented Sep 1, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Sep 1, 2021

I have automatically backported this PR to "13-x-y", please check out #30782

@trop
Copy link
Contributor

trop bot commented Sep 1, 2021

I have automatically backported this PR to "14-x-y", please check out #30783

@trop
Copy link
Contributor

trop bot commented Sep 1, 2021

I have automatically backported this PR to "15-x-y", please check out #30784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants