Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable v8 oilpan #30853

Merged
merged 2 commits into from
Sep 7, 2021
Merged

chore: enable v8 oilpan #30853

merged 2 commits into from
Sep 7, 2021

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Sep 6, 2021

Description of Change

Follow-up to #30370

Release Notes

Notes: none

@deepak1556 deepak1556 requested a review from a team as a code owner September 6, 2021 09:25
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2021
@deepak1556 deepak1556 added backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Sep 6, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2021
@deepak1556 deepak1556 added 15-x-y new-pr 🌱 PR opened in the last 24 hours labels Sep 6, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2021
@codebytere codebytere merged commit 9f39865 into 15-x-y Sep 7, 2021
@codebytere codebytere deleted the robo/fix_v8_oilpan_15_x_y branch September 7, 2021 07:41
@release-clerk
Copy link

release-clerk bot commented Sep 7, 2021

No Release Notes

@nornagon
Copy link
Member

nornagon commented Sep 7, 2021

@deepak1556 no need for release notes for this sort of thing which should not be observable to most devs. I've updated the clerk comment and the description, but just FYI.

@deepak1556
Copy link
Member Author

Sounds good, at the time of writing I was not sure about it, this kind of change usually goes through a roll which indicates to user that things can change in chromium versions but this was made outside a roll and it is a feature that may or may not break for end users, so thought that release notes might help highlight the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants