fix: suppress insecure resource warning for more local hostnames #30885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
previously approved these changes
Sep 8, 2021
| const isLocal = (url: URL): boolean => | ||
| ['localhost', '127.0.0.1', '[::1]', ''].includes(url.hostname); | ||
| const isInsecure = (url: URL): boolean => | ||
| ['http:', 'ftp:'].includes(url.protocol) && !isLocal(url); |
There was a problem hiding this comment.
ftp urls will no longer resolve in main since #30503 :)
https://bugs.chromium.org/p/chromium/issues/detail?id=333943
zcbenz
approved these changes
Sep 21, 2021
|
No Release Notes |
This was referenced Sep 21, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31035 |
|
I have automatically backported this PR to "15-x-y", please check out #31036 |
|
I have automatically backported this PR to "14-x-y", please check out #31037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Suppress security warnings for 127.0.0.1, [::1] and about:blank in addition to
'localhost'. Closes #30880.
Checklist
npm testpassesRelease Notes
Notes: none