-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: draggable regions in BrowserView
s are independent
#31085
Conversation
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #31197 |
I have automatically backported this PR to "15-x-y", please check out #31198 |
I have automatically backported this PR to "16-x-y", please check out #31199 |
I have automatically backported this PR to "14-x-y", please check out #31200 |
Description of Change
Closes #31068
Closes #31052.
After #26145, it was possible to make draggable regions on BrowserViews independent from those of BrowserWindows. As such, if a BrowserView with different draggable regions than the BrowserWindow it belongs to is superimposed on top of that window, the draggable regions of the BrowserView take precedence over those of the BrowserWindow. This is fixed by having each BrowseView update its own draggable regions in
BrowserWindow::UpdateDraggableRegions
instead of inheriting those coming in fromBrowserWindow::UpdateDraggableRegions
.Tested with https://gist.github.com/0a53108546ef22e4d03e1b6dea55a79a and https://github.com/devinbinnie/electron-quick-start/tree/draggable_areas_bv_macos
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where changes to draggable regions in a
BrowserWindow
incorrectly affected those in an attachedBrowserView
.