Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use native WeakRef instead of v8util.weaklyTrackValue() #31164

Merged
merged 1 commit into from
Sep 28, 2021
Merged

refactor: use native WeakRef instead of v8util.weaklyTrackValue() #31164

merged 1 commit into from
Sep 28, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 27, 2021

Backport of #31153

See that PR for details.

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2021
@trop trop bot requested a review from miniak September 27, 2021 20:51
@trop trop bot mentioned this pull request Sep 27, 2021
Merged
3 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2021
@codebytere codebytere merged commit c7b4f41 into 14-x-y Sep 28, 2021
@codebytere codebytere deleted the trop/14-x-y-bp-refactor-use-native-weakref-instead-of-v8util-weaklytrackvalue--1632775870489 branch September 28, 2021 08:15
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2021

No Release Notes

codebytere pushed a commit that referenced this pull request Sep 28, 2021
@trop @miniak @codebytere
refactor: use native WeakRef instead of v8util.weaklyTrackValue() (#3…
70ecaff 
…1164)

Co-authored-by: Milan Burda <milan.burda@gmail.com>
jkleinsc pushed a commit that referenced this pull request Sep 29, 2021
@codebytere @trop @miniak
refactor: use native WeakRef instead of v8util.weaklyTrackValue() (#3…
acb2209 
…1164) (#31169)

Co-authored-by: Milan Burda <milan.burda@gmail.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @miniak