fix: remove NOTREACHED() from GetWindowResizeEdge
#31470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deermichel
approved these changes
Oct 19, 2021
codebytere
approved these changes
Oct 19, 2021
|
Release Notes Persisted
|
This was referenced Oct 19, 2021
|
I have automatically backported this PR to "16-x-y", please check out #31479 |
|
I have automatically backported this PR to "15-x-y", please check out #31480 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previously in a test build on Windows, when a window was maximized and restored by moving it to the top edge of the window and subsequently pulling it away, the default case of the switch statement in
GetWindowResizeEdgewould get hit. This would result in a debug check returning false and crashing the program.By removing this
NOTREACHED()call, the test build program does not crash.@deermichel
Checklist
npm testpassesRelease Notes
Notes: None