Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: media shouldn't open permissions dialog #31837

Merged
merged 2 commits into from
Nov 15, 2021
Merged

fix: media shouldn't open permissions dialog #31837

merged 2 commits into from
Nov 15, 2021

Commits on Nov 15, 2021

  1. fix: media shouldn't open permissions dialog 

    Playing media shouldn't open Accessibility permissions dialog on macOS.
However, we still need to watch for media events, just not globally and
`media_keys_listener_` is an API over global capture of the media keys.

The fix is to let chromium call `UpdateWhichKeysAreListenedFor` which
will call `UpdateSystemMediaControlsEnabledControls` and watch for
events on `system_media_controls_` without triggering permissions popup.
    @indutny @electron-bot
    indutny authored and electron-bot committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    401fd90 View commit details
    Browse the repository at this point in the history

  2. chore: update patches

    @patchup @electron-bot
    patchup[bot] authored and electron-bot committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    d59812b View commit details
    Browse the repository at this point in the history