Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ninja build failed on some system #31887

Merged
merged 1 commit into from
Nov 22, 2021
Merged

fix: ninja build failed on some system #31887

merged 1 commit into from
Nov 22, 2021

Conversation

BlackHole1
Copy link
Member

Description of Change

enabling --openssl-no-asm for all platforms

Related PR: #31404

cc: @zcbenz

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 18, 2021
@zcbenz zcbenz added target/14-x-y semver/patch backwards-compatible bug fixes labels Nov 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 19, 2021
@BlackHole1
Copy link
Member Author

@zcbenz Is there anything else that needs to be modified?

@zcbenz zcbenz merged commit 38d2ec0 into electron:main Nov 22, 2021
@release-clerk
Copy link

release-clerk bot commented Nov 22, 2021

No Release Notes

This was referenced Nov 22, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "14-x-y", please check out #31941

@trop trop bot mentioned this pull request Nov 22, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "15-x-y", please check out #31942

@trop trop bot mentioned this pull request Nov 22, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "16-x-y", please check out #31943

@trop trop bot removed the target/15-x-y label Nov 22, 2021
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "17-x-y", please check out #31944

@BlackHole1 BlackHole1 deleted the fix-build-failed branch November 22, 2021 00:53
@trop trop bot added the merged/17-x-y label Nov 22, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@BlackHole1 @t57ser
fix: ninja build failed on some system (electron#31887)
e7a4f88
@commit-lint commit-lint bot mentioned this pull request Feb 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BlackHole1 @zcbenz