Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint Objective-C header files #31923

Merged
merged 1 commit into from Nov 22, 2021
Merged

fix: lint Objective-C header files #31923

merged 1 commit into from Nov 22, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Nov 20, 2021 •
edited

Description of Change

Add missing linting for Objective-C headers and cleanup IGNORELIST in script/lint.js

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2021
@miniak miniak force-pushed the miniak/lint-ignorelist-cleanup branch from 78dc558 to f624013 Compare November 20, 2021 00:10
@miniak miniak changed the title chore: cleanup IGNORELIST in script/lint.js fix: lint Objective-C header files Nov 20, 2021
@miniak miniak self-assigned this Nov 20, 2021
@miniak miniak force-pushed the miniak/lint-ignorelist-cleanup branch from f624013 to 0e69293 Compare November 20, 2021 00:16
@miniak miniak added semver/patch backwards-compatible bug fixes target/14-x-y labels Nov 20, 2021
@miniak miniak force-pushed the miniak/lint-ignorelist-cleanup branch from 0e69293 to 711a4c3 Compare November 20, 2021 00:28
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 21, 2021
@zcbenz zcbenz merged commit 7ff1503 into main Nov 22, 2021
@zcbenz zcbenz deleted the miniak/lint-ignorelist-cleanup branch November 22, 2021 00:36
@release-clerk
Copy link

release-clerk bot commented Nov 22, 2021

No Release Notes

This was referenced Nov 22, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "14-x-y", please check out #31937

@trop trop bot mentioned this pull request Nov 22, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "15-x-y", please check out #31938

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "16-x-y", please check out #31939

@trop
Copy link
Contributor

trop bot commented Nov 22, 2021

I have automatically backported this PR to "17-x-y", please check out #31940

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@miniak @t57ser
fix: lint Objective-C header files (electron#31923)
4bd8ac4
@commit-lint commit-lint bot mentioned this pull request Feb 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @deepak1556