Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct webFrame description #32205

Merged
merged 1 commit into from
Jan 4, 2022
Merged

docs: correct webFrame description #32205

merged 1 commit into from
Jan 4, 2022

Conversation

mckravchyk
Copy link
Contributor

@mckravchyk mckravchyk commented Dec 16, 2021

Description of Change

The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added

Release Notes

Notes: none

The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.
@welcome
Copy link

welcome bot commented Dec 16, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 23, 2021
@zcbenz zcbenz merged commit 84f1d78 into electron:main Jan 4, 2022
@welcome
Copy link

welcome bot commented Jan 4, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 4, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "16-x-y", please check out #32326

@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "17-x-y", please check out #32327

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants