Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node test failure #32408

Merged
merged 1 commit into from Jan 11, 2022
Merged

fix: node test failure #32408

merged 1 commit into from Jan 11, 2022

Conversation

jkleinsc
Copy link
Contributor

Description of Change

CI is running into nodejs/node#36591 on 13-x-y, so this PR backports the fix for that issue to 13-x-y.

Checklist

Release Notes

Notes: none

@jkleinsc
fix: node test failure
407eb25 
Resolves nodejs/node#36591, which is currently happening on 13-x-y
@jkleinsc jkleinsc added the backport-check-skip Skip trop's backport validity checking label Jan 10, 2022
@jkleinsc jkleinsc requested a review from a team as a code owner January 10, 2022 20:43
@jkleinsc jkleinsc mentioned this pull request Jan 10, 2022
Merged
@jkleinsc jkleinsc merged commit 87863e2 into 13-x-y Jan 11, 2022
@jkleinsc jkleinsc deleted the fix-13-node-test branch January 11, 2022 01:14
@release-clerk
Copy link

release-clerk bot commented Jan 11, 2022

No Release Notes

@jkleinsc jkleinsc mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
backport-check-skip Skip trop's backport validity checking semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @ckerr @codebytere