Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update context bridge docs about Promises and Errors #32645

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 27, 2022

Backport of #32533

See that PR for details.

Notes: Updated context bridge docs about Promises and Errors.

* Update context bridge docs about Promises

From my testing it doesn't remove Promises in nested objects,
also according to the test suite it does not:
https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693

* docs: Update docs for errors too
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 27, 2022
@trop trop bot added 16-x-y backport This is a backport PR semver/none labels Jan 27, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 27, 2022
@codebytere codebytere merged commit 41926c1 into 16-x-y Jan 27, 2022
@codebytere codebytere deleted the trop/16-x-y-bp-docs-update-context-bridge-docs-about-promises-and-errors-1643282640418 branch January 27, 2022 13:44
@release-clerk
Copy link

release-clerk bot commented Jan 27, 2022

Release Notes Persisted

Updated context bridge docs about Promises and Errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants