Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose all serial devices to setDevicePermissionHandler #32687

Merged
merged 1 commit into from Feb 1, 2022
Merged

fix: expose all serial devices to setDevicePermissionHandler #32687

merged 1 commit into from Feb 1, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 31, 2022

Backport of #32651

See that PR for details.

Notes: fixed issue where not all serial devices were exposed to the handler specified by session.setDevicePermissionHandler

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2022
@trop trop bot requested a review from jkleinsc January 31, 2022 19:05
@trop trop bot mentioned this pull request Jan 31, 2022
Merged
3 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2022
@zcbenz zcbenz merged commit 7d5d1a1 into 16-x-y Feb 1, 2022
@zcbenz zcbenz deleted the trop/16-x-y-bp-fix-expose-all-serial-devices-to-setdevicepermissionhandler-1643655901436 branch February 1, 2022 11:22
@release-clerk
Copy link

release-clerk bot commented Feb 1, 2022

Release Notes Persisted

fixed issue where not all serial devices were exposed to the handler specified by session.setDevicePermissionHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @zcbenz