Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fix for 1281979 from chromium #32785

Merged
merged 7 commits into from Feb 17, 2022

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Feb 8, 2022

Subject: Fix race condition while initializing GPU Watchdog

This CL is fixing a race condition detected by TSAN.
see: crbug/1281979

The race condition is between these two functions:
base::PowerMonitor::IsInitialized() and
base::PowerMonitor::Initialize(...)

The power monitor doesn't need to be initialized to add
observers. In fact, the power monitor initialization
is for plugging a power monitor source. Observers can be
safely added/removed.

Bug: 1281979

Notes: Security: backported fix for chromium:1281979.

@zcbenz zcbenz requested a review from a team as a code owner February 8, 2022 04:48
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@zcbenz zcbenz added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking labels Feb 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@zcbenz zcbenz added the 15-x-y label Feb 8, 2022
@zcbenz zcbenz merged commit 4615dcb into 15-x-y Feb 17, 2022
@zcbenz zcbenz deleted the cherry-pick/15-x-y/chromium/1281979 branch February 17, 2022 12:07
@release-clerk
Copy link

release-clerk bot commented Feb 17, 2022

Release Notes Persisted

Security: backported fix for chromium:1281979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants